[ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

[Simon Horman]

On 25 July 2018 at 23:13, Justin Pettit <jpettit at ovn.org> wrote:

>
> > On Jul 25, 2018, at 9:17 AM, Simon Horman <simon.horman at netronome.com>
> wrote:
> >
> > On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote:
> >>
> >> it could.
> >> currently offload unit tests in the repo fail and needs an update
> >> though they cannot be fixed because they use veth and test dump
> >> using type=offloaded to verify rules in tc.
> >> this patch adds the possibility again to check rules in tc.
> >> then we can fix the offload unit tests.
> >> besides this nothing is really broken.
> >
> > I believe the freeze is now over, I have applied this patch to the master
> > branch.
>
> Hi, Simon.  This patch broke the build and a number of unit tests, so I
> sent out a patch to revert it (and the subsequent build breakage patch):
>
>         https://mail.openvswitch.org/pipermail/ovs-dev/2018-July/
> 350128.html
>
> It appears that Roi indicated some unit tests were failing also (but it
> sounds like those might be related to system unit tests as opposed to the
> general ones).  Are you running the unit tests before you commit code?
>
> On a less important note, it contains a number of lines that are over 79
> characters, which is discouraged by the coding style guide.
>

Sorry about this, I was not as thorough as I usually am before applying a
patch.