[ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

Simon Horman simon.horman at netronome.com
Thu Jul 26 20:19:09 UTC 2018


On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote:
> Support matching on tos and ttl of ip tunnels
> for the TC data-path.
> 
> Signed-off-by: Or Gerlitz <ogerlitz at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>
> ---

...

> diff --git a/lib/tc.c b/lib/tc.c
> index aa3147f..f5901d1 100644
> --- a/lib/tc.c
> +++ b/lib/tc.c
> @@ -298,6 +298,10 @@ static const struct nl_policy tca_flower_policy[] = {
>                                            .optional = true, },
>      [TCA_FLOWER_KEY_FLAGS] = { .type = NL_A_BE32, .optional = true, },
>      [TCA_FLOWER_KEY_FLAGS_MASK] = { .type = NL_A_BE32, .optional = true, },
> +    [TCA_FLOWER_KEY_TCP_FLAGS] = { .type = NL_A_U16,
> +                                   .optional = true, },
> +    [TCA_FLOWER_KEY_TCP_FLAGS_MASK] = { .type = NL_A_U16,
> +                                        .optional = true, },
>      [TCA_FLOWER_KEY_IP_TTL] = { .type = NL_A_U8,
>                                  .optional = true, },
>      [TCA_FLOWER_KEY_IP_TTL_MASK] = { .type = NL_A_U8,

The above hunk appears to duplicate existing initialisation of the same
indexes of the array. Perhaps it should be dropped?

...


More information about the dev mailing list