[ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

[Or Gerlitz]

On Thu, Jul 26, 2018 at 11:19 PM, Simon Horman
<simon.horman at netronome.com> wrote:
> On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote:

>> +++ b/lib/tc.c
>> @@ -298,6 +298,10 @@ static const struct nl_policy tca_flower_policy[] = {
>>                                            .optional = true, },
>>      [TCA_FLOWER_KEY_FLAGS] = { .type = NL_A_BE32, .optional = true, },
>>      [TCA_FLOWER_KEY_FLAGS_MASK] = { .type = NL_A_BE32, .optional = true, },
>> +    [TCA_FLOWER_KEY_TCP_FLAGS] = { .type = NL_A_U16,
>> +                                   .optional = true, },
>> +    [TCA_FLOWER_KEY_TCP_FLAGS_MASK] = { .type = NL_A_U16,
>> +                                        .optional = true, },


> The above hunk appears to duplicate existing initialisation of the same
> indexes of the array. Perhaps it should be dropped?

sure, I will fix it up, thanks for the catch!