[ovs-dev] [ovs-dev, ACL, Meters, 4 of 7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

0-day Robot robot at bytheb.org
Mon Jul 30 07:02:22 UTC 2018


Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#217 FILE: ovn/ovn-nb.ovsschema:202:
                                          "enum": ["set", ["kbps", "pktps"]]}}},

WARNING: Line is 80 characters long (recommended limit is 79)
#358 FILE: ovn/ovn-sb.ovsschema:105:
                                          "enum": ["set", ["kbps", "pktps"]]}}},

WARNING: Line is 129 characters long (recommended limit is 79)
#473 FILE: ovn/utilities/ovn-nbctl.8.xml:177:
        <dt><code>meter-add</code> <var>name</var> <var>unit</var> <var>action</var> <var>rate</var> [<var>burst_size</var>]</dt>

WARNING: Line lacks whitespace around operator
#533 FILE: ovn/utilities/ovn-nbctl.c:500:
  meter-add NAME UNIT ACTION RATE [BURST_SIZE]\n\

WARNING: Line lacks whitespace around operator
#535 FILE: ovn/utilities/ovn-nbctl.c:502:
  meter-del [NAME]          remove meters\n\

WARNING: Line lacks whitespace around operator
#536 FILE: ovn/utilities/ovn-nbctl.c:503:
  meter-list                print meters\n\

Lines checked: 764, Warnings: 6, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list