[ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

Roi Dayan roid at mellanox.com
Mon Jul 30 07:09:14 UTC 2018



On 27/07/2018 14:00, Simon Horman wrote:
> Hi Gavi,
> 
> On 26 July 2018 at 17:36, Justin Pettit <jpettit at ovn.org <mailto:jpettit at ovn.org>> wrote:
> 
> 
>     > On Jul 26, 2018, at 7:29 AM, Gavi Teitz <gavi at mellanox.com <mailto:gavi at mellanox.com>> wrote:
>     > 
>     > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM:
>     >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a number of issues with style, build breakage, and failing unit tests.
>     >> The patch is being reverted so that they can addressed.
>     > 
>     > I acknowledge the build breakage issue, could you elaborate regarding the style issues?
> 
>     The main style issue was that lines shouldn't be over 79 characters longs.
> 
>     > As for the failing unit tests, this commit provides the means to fix unit tests that lost their relevance due to the changes introduced in commit d63ca5329ff9 ("dpctl: Properly reflect a rule's offloaded to HW state"). Are there other unit tests that are broken due to this commit?
> 
>     I saw about a dozen unit tests failing when I ran "make check".
> 
> 
> I believe this gives an overview of the failing tests:
> 
> https://travis-ci.org/horms2/ovs/jobs/408446254 <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fhorms2%2Fovs%2Fjobs%2F408446254&data=02%7C01%7Croid%40mellanox.com%7Cf5f8d6b35d8648f7c1fa08d5f3b04e7f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636682860947190671&sdata=hkRIPzuKSEzCR6lzchvbQKYL%2B%2F4kNukN5voglAE5QGw%3D&reserved=0>


sorry all about this. we missed it internally.
next time we'll make sure we do all needed testing before submitting.
we usually do submit to travis to run all internal checks.
we probably missed it with this patch.

as for what Gavi mean about the needing the commit to fix the tests
it's for the offload tests only.


More information about the dev mailing list