[ovs-dev] [ovs-dev, v3, 2 of 6] ipsec: reintroduce IPsec support for tunneling

Aaron Conole aconole at redhat.com
Mon Jul 30 12:29:35 UTC 2018

0-day Robot <robot at bytheb.org> writes:

> Bleep bloop.  Greetings Qiuyu Xiao, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> I encountered some error that I wasn't expecting.  See the details below.
> checkpatch:
> ERROR: Too many signoffs; are you missing Co-authored-by lines?

My understanding is that there should be a 'Signed-off-by' tag from the
principal or submitter, and a Signed-off-by: and Co-authored-by from
each co-author.

Maybe it would be better match the tags and ignore these kinds of cases
(where each 'co-author' adds both tags)?

> WARNING: Line has trailing whitespace
> #522 FILE: ipsec/ovs-monitor-ipsec:456:
>             self.secrets_file.write('%s %s : PSK "%s"\n' % 
> WARNING: Line is 80 characters long (recommended limit is 79)
> WARNING: Line has trailing whitespace
> #523 FILE: ipsec/ovs-monitor-ipsec:457:
>                             (tunnel.conf["local_ip"], tunnel.conf["remote_ip"], 
> Lines checked: 1228, Warnings: 3, Errors: 1
> Please check this out.  If you feel there has been an error, please email aconole at bytheb.org
> Thanks,
> 0-day Robot
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

More information about the dev mailing list