[ovs-dev] [PATCH 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

Jakub Sitnicki jkbs at redhat.com
Mon Jul 30 14:40:12 UTC 2018

On Sat, 28 Jul 2018 23:54:32 -0700
Han Zhou <zhouhan at gmail.com> wrote:

> On Thu, Jul 26, 2018 at 3:51 AM, Jakub Sitnicki <jkbs at redhat.com> wrote:
> >
> > If a logical switch port belongs to a port group and has dynamic
> > addresses assigned, propagate the addresses to the auto-generated
> > address sets for the port group.
> >
> > Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
> > ---


> Thanks for the fix! Just a minor problem:
> It would be better to check if the address is dynamic using
> is_dynamic_lsp_address() before calling split_addresses(). Otherwise, there
> seems to be annoying INFO log: "invalid syntax '%s' in address" printed if
> the address is "dynamic".
> Acked-by: Han Zhou <hzhou8 at ebay.com>

Thanks a lot for the review, Han. I've posted v2 with the suggested fix
and kept your acks:



More information about the dev mailing list