[ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

Ben Pfaff blp at ovn.org
Mon Jul 30 19:49:51 UTC 2018


On Sun, Jul 29, 2018 at 11:46:37PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit at ovn.org>

In ofproto_check_ofpacts(), the other checks, if they fail, return an
error and prevent the flow from being added.  The new one doesn't; is
the difference intentional?  Similarly, is there anything that prevents
a meter from being deleted while still in use and, if that happens, does
anything particularly bad happen?

In ovs-ofctl.8.in, the wording seems a little vague because "associate"
is such a weak word.  Maybe change
    Associate packets sent to the controller with meter \fIid\fR.
to
    Use meter \fIid\fR to rate-limit the OpenFlow packet-in messages
    that this action sends to the controller.
or something similarly descriptive

Do only "drop" actions make sense for controller metering?

Please add some tests for the new action to the test "ovn -- action
parsing" in ovn.at.

Please document the new action in ovn-sb.xml.

Acked-by: Ben Pfaff <blp at ovn.org>

Thanks,

Ben.


More information about the dev mailing list