[ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

Ben Pfaff blp at ovn.org
Mon Jul 30 20:35:13 UTC 2018


On Mon, Jul 30, 2018 at 01:09:12PM -0700, Justin Pettit wrote:
> 
> > On Jul 30, 2018, at 10:43 AM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > On Sun, Jul 29, 2018 at 11:46:34PM -0700, Justin Pettit wrote:
> >> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> > 
> > Thanks for the patches!
> > 
> > I think that group_table_list() is very similar or identical to
> > meter_table_list() in the previous patch.  Is it possible to write both
> > of them in terms of a common helper function?
> 
> Yes, that's true right now.  I have some patches in my local repo that
> will dump information specific to the type of table.  Unfortunately, I
> ran out of time for this release, so it provides just the most basic
> information right now.  I'd prefer to keep them separate since there
> should be a quick follow on that will make them quite different.

That's reasonable, thanks.


More information about the dev mailing list