[ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

Justin Pettit jpettit at ovn.org
Tue Jul 31 00:58:53 UTC 2018


> On Jul 30, 2018, at 12:55 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> 
> Besides the comments I gave on patch 6 (oops), I suggest the following
> for more consistent formatting:
> 
> diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
> index 6d4ed1e2c4ed..4f3cd48ce713 100644
> --- a/ovn/lib/actions.c
> +++ b/ovn/lib/actions.c
> @@ -2157,7 +2157,7 @@ format_LOG(const struct ovnact_log *log, struct ds *s)
>     ds_put_format(s, "severity=%s", log_severity_to_string(log->severity));
> 
>     if (log->meter) {
> -        ds_put_format(s, ",meter=%s", log->meter);
> +        ds_put_format(s, ", meter=%s", log->meter);
>     }
> 
>     ds_put_cstr(s, ");");

Applied.

> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the review!  I've pushed this series to master.

--Justin




More information about the dev mailing list