[ovs-dev] [PATCH] ofctrl: Placate GCC.

Ben Pfaff blp at ovn.org
Tue Jul 31 17:16:14 UTC 2018


On Tue, Jul 31, 2018 at 10:01:40AM -0700, Justin Pettit wrote:
> 
> > On Jul 31, 2018, at 9:57 AM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > Some GCC versions don't like ".x.y =", complaining about an uninitialized
> > field.
> > 
> > Without this patch we get travis failures, e.g.
> > https://travis-ci.org/openvswitch/ovs/jobs/410404752:
> > 
> >    ovn/controller/ofctrl.c: In function ‘ofctrl_put’:
> >    ovn/controller/ofctrl.c:1086:9: error: missing initializer for field ‘flags’ of ‘struct ofputil_meter_config’ [-Werror=missing-field-initializers]
> >             };
> >             ^
> >    In file included from ovn/controller/ofctrl.c:35:0:
> >    ./include/openvswitch/ofp-meter.h:53:14: note: ‘flags’ declared here
> >         uint16_t flags;
> >                  ^
> > 
> > With it, it passes.
> > 
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks, applied.


More information about the dev mailing list