[ovs-dev] [patch v8 2/9] flow: Enhance parse_ipv6_ext_hdrs.

Justin Pettit jpettit at ovn.org
Tue Jul 31 17:22:45 UTC 2018


> On Jul 16, 2018, at 7:39 PM, Darrell Ball <dlu998 at gmail.com> wrote:
> 
> diff --git a/lib/flow.c b/lib/flow.c
> index 76a8b9a..e84a40d 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -453,9 +453,14 @@ invalid:
>     return true;
> }
> 
> +/* datap points to the first extension header and advances as parsing
> + * occurs; sizep is the remaining size and is decreased accordingly.
> + * nw_proto starts as the first extension header to process and is
> + * updated as the extension headers are parsed. */
> static inline bool
> parse_ipv6_ext_hdrs__(const void **datap, size_t *sizep, uint8_t *nw_proto,
> -                      uint8_t *nw_frag)
> +                      uint8_t *nw_frag,
> +                      const struct ovs_16aligned_ip6_frag **frag_hdr)

I think this comment could use some more explanation.  Does the following seem correct?

/* Parses IPv6 extenstion headers until a terminal header (or header we
 * don't understand) is found.  'datap' points to the first extension
 * header and advances as parsing occurs; 'sizep' is the remaining size
 * and is decreased accordingly.  'nw_proto' starts as the first
 * extension header to process and is updated as the extension headers
 * are parsed.
 *
 * If a fragment header is found, '*frag_hdr' is set to the fragment
 * header.  If it is the first fragment, extension header parsing
 * otherwise continues as usual.  If it's not the first fragment,
 * 'nw_proto' is set to IPPROTO_FRAGMENT and 'nw_frag' has
 * FLOW_NW_FRAG_ANY set.  Additionally, if it's not the first fragment
 * and there are more fragments, 'nw_frag' will also have
 * FLOW_NW_FRAG_LATER set. */

Also, I think this should go with parse_ipv6_ext_hdrs(), since it's the public function.

If you go agree with all of this, I'll go ahead and make the changes myself.

--Justin




More information about the dev mailing list