[ovs-dev] [PATCH 09/13] ofproto-dpif-trace: Remove tabs from output.

Ben Pfaff blp at ovn.org
Mon Jun 4 21:27:46 UTC 2018


OVS uses spaces for indentation in source code and it makes sense for it to
also use spaces for indentation in output.  Spaces also consume less
horizontal space in output, which often makes it easier to read.  This
commit transitions one part of output from tabs to spaces and updates
appropriate parts of the tests to match.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 ofproto/ofproto-dpif-trace.c | 2 +-
 tests/bfd.at                 | 4 ++--
 tests/ofproto-dpif.at        | 4 ++--
 tests/system-traffic.at      | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c
index 396a06ba0a6c..5f38cae16e22 100644
--- a/ofproto/ofproto-dpif-trace.c
+++ b/ofproto/ofproto-dpif-trace.c
@@ -637,7 +637,7 @@ ofproto_trace__(struct ofproto_dpif *ofproto, const struct flow *flow,
         while (slow) {
             enum slow_path_reason bit = rightmost_1bit(slow);
 
-            ds_put_format(output, "\n\t- %s.",
+            ds_put_format(output, "\n  - %s.",
                           slow_path_reason_to_explanation(bit));
 
             slow &= ~bit;
diff --git a/tests/bfd.at b/tests/bfd.at
index b0b7a2f9fe27..97da74217256 100644
--- a/tests/bfd.at
+++ b/tests/bfd.at
@@ -241,7 +241,7 @@ AT_CHECK([ovs-appctl ofproto/trace --l7-len 0 ovs-dummy 'tunnel(tun_id=0x1,src=2
 # check that the packet should be handled as BFD packet.
 AT_CHECK([tail -2 stdout], [0], [dnl
 This flow is handled by the userspace slow path because it:
-	- Consists of BFD packets.
+  - Consists of BFD packets.
 ], [])
 
 # turn on the check_tnl_key.
@@ -258,7 +258,7 @@ AT_CHECK([ovs-appctl ofproto/trace --l7-len 0 ovs-dummy 'tunnel(tun_id=0x0,src=2
 # check that the packet should be handled as BFD packet.
 AT_CHECK([tail -2 stdout], [0], [dnl
 This flow is handled by the userspace slow path because it:
-	- Consists of BFD packets.
+  - Consists of BFD packets.
 ], [])
 
 OVS_VSWITCHD_STOP
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index f9ae8b28213c..41b7a496617e 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -271,7 +271,7 @@ AT_CHECK([tail -4 stdout], [0],
   [Megaflow: recirc_id=0,eth,icmp6,in_port=1,nw_frag=no,icmp_type=0x87/0xff,icmp_code=0x0/0xff,nd_target=fe80::2020,nd_sll=66:55:44:33:22:11
 Datapath actions: 10,set(nd(target=fe80::4,sll=cc:cc:cc:cc:cc:cc)),11,set(nd(target=fe80::3,sll=aa:aa:aa:aa:aa:aa)),13
 This flow is handled by the userspace slow path because it:
-	- Uses action(s) not supported by datapath.
+  - Uses action(s) not supported by datapath.
 ])
 OVS_VSWITCHD_STOP
 AT_CLEANUP
@@ -5173,7 +5173,7 @@ flow="in_port(1),eth(src=50:54:00:00:00:05,dst=50:54:00:00:00:07),eth_type(0x080
 AT_CHECK([ovs-appctl ofproto/trace ovs-dummy "$flow" -generate], [0], [stdout])
 AT_CHECK_UNQUOTED([tail -3 stdout], [0], [Datapath actions: 2
 This flow is handled by the userspace slow path because it:
-	- Uses action(s) not supported by datapath.
+  - Uses action(s) not supported by datapath.
 ])
 
 OVS_VSWITCHD_STOP
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 2c741619eb93..7080efeb29b0 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -725,7 +725,7 @@ AT_CHECK([ovs-appctl ofproto/trace br0 "in_port=1,dl_type=0x800,dl_src=e6:66:c1:
 AT_CHECK([tail -3 stdout], [0],
 [Datapath actions: trunc(100),3,5,trunc(100),3,trunc(100),5,3,trunc(200),5,trunc(65535),3
 This flow is handled by the userspace slow path because it:
-	- Uses action(s) not supported by datapath.
+  - Uses action(s) not supported by datapath.
 ])
 
 dnl SLOW_ACTION test2: check actual packet truncate
-- 
2.16.1



More information about the dev mailing list