[ovs-dev] [PATCH] tests/stp: Make validation of flows before changing of topology.

Ilya Maximets i.maximets at samsung.com
Tue Jun 5 14:37:42 UTC 2018

From: Ivan Dyukov <i.dyukov at samsung.com>

The change fixes random stp test failure. Accuracy is about 20%.
Failed test is following:
2337: STP - flush the fdb and mdb when topology changed

In some cases, a validation is executed after topology change and
it increase time of stp stabilization. To prevent this, delay
which wait validation is added before deleting a port.

CC: Tonghao Zhang <xiangxia.m.yue at gmail.com>
Fixes: 427e9751f300 ("tests: Add and improve stp tests.")
Signed-off-by: Ivan Dyukov <i.dyukov at samsung.com>
 tests/stp.at | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/stp.at b/tests/stp.at
index 9550f72..8a0a868 100644
--- a/tests/stp.at
+++ b/tests/stp.at
@@ -562,6 +562,9 @@ OVS_WAIT_UNTIL([ovs-appctl mdb/show br0 | grep 'querier'])
 OVS_WAIT_UNTIL([ovs-appctl mdb/show br1 | grep 'querier'])
 OVS_WAIT_UNTIL([ovs-appctl mdb/show br2 | grep 'querier'])
+# Make sure that  validation of flows was before changing of topology.
+ovs-appctl revalidator/wait
 # del p2 on the br0, the topology will be changed
 AT_CHECK([ovs-vsctl del-port br0 p2])

More information about the dev mailing list