[ovs-dev] [PATCH 1/5] ovn-controller: Style fixes.

Han Zhou zhouhan at gmail.com
Mon Jun 11 17:48:24 UTC 2018


On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff <blp at ovn.org> wrote:
> diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c
> index d09fd107298b..db96197828aa 100644
> --- a/ovn/controller/lflow.c
> +++ b/ovn/controller/lflow.c
> @@ -65,8 +65,6 @@ static void consider_logical_flow(struct controller_ctx
*ctx,
>                                    const struct chassis_index
*chassis_index,
>                                    const struct sbrec_logical_flow *lflow,
>                                    const struct hmap *local_datapaths,
> -                                  struct ovn_extend_table *group_table,
> -                                  struct ovn_extend_table *meter_table,
>                                    const struct sbrec_chassis *chassis,
>                                    struct hmap *dhcp_opts,
>                                    struct hmap *dhcpv6_opts,
> @@ -74,9 +72,11 @@ static void consider_logical_flow(struct
controller_ctx *ctx,
>                                    uint32_t *conj_id_ofs,

conj_id_ofs is input but also output, so should it be put after the input
parameters?

>                                    const struct shash *addr_sets,
>                                    const struct shash *port_groups,
> +                                  const struct sset *active_tunnels,
> +                                  const struct sset *local_lport_ids,
>                                    struct hmap *flow_table,
> -                                  struct sset *active_tunnels,
> -                                  struct sset *local_lport_ids);
> +                                  struct ovn_extend_table *group_table,
> +                                  struct ovn_extend_table *meter_table);


In addition, it seems "const" should be added for "struct sset *lports" of
function update_ct_zones() in ovn-controller.c.

Acked-by: Han Zhou <hzhou8 at ebay.com>

Thanks,
Han


More information about the dev mailing list