[ovs-dev] [PATCH] rhel: remove ovs-sim man page from temporary directory (also for RHEL)

Ben Pfaff blp at ovn.org
Thu Jun 14 20:44:43 UTC 2018


On Thu, Jun 07, 2018 at 10:17:53AM +0300, Roi Dayan wrote:
> 
> 
> On 06/06/2018 08:49, Ansis Atteka wrote:
> > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff <blp at ovn.org> wrote:
> >>
> >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote:
> >>> Fix following compilation error when building rpm packages
> >>> with rhel/openvswitch.spec file.
> >>>
> >>> error: Installed (but unpackaged) file(s) found:
> >>>    /usr/share/man/man1/ovs-sim.1.gz
> >>>
> >>> Signed-off-by: Ansis Atteka <aatteka at ovn.org>
> >>
> >> Seems reasonable.
> >>
> >> Acked-by: Ben Pfaff <blp at ovn.org>
> > 
> > Thanks for review, pushed it to master branch.
> 
> what about "make install" ?
> Should ovs-sim.1 be ignored from being installed with "make install" ?
> currently it is installed and being removed later when building rpm.

Good point.  I failed to consider the big picture.

Here's an improvement:
        https://patchwork.ozlabs.org/patch/929707/


More information about the dev mailing list