[ovs-dev] [PATCH 0/3] add TCP/UDP port unreachable support to OVN logical router

Ben Pfaff blp at ovn.org
Fri Jun 15 18:44:55 UTC 2018


On Fri, Jun 15, 2018 at 11:49:06AM +0200, Lorenzo Bianconi wrote:
> Add TCP reset/ICMP port unreachable messages in reply to IP packets directed to
> the logical router's IP addresses

Thanks for implementing this!

I noticed a needlessly inefficient pattern here, where the actions are
a fixed string yet the code copies it into a dynamic string and later
frees it.  Would you mind just using a string literal in those cases?

Thanks,

Ben.


More information about the dev mailing list