[ovs-dev] [PATCH v2 0/3] Optimize conntrack performance

Anand Kumar kumaranand at vmware.com
Tue Jun 19 17:34:53 UTC 2018


Hi Alin,

Thanks for running the code analysis on the patch series.
As discussed in the Hyper-V meeting, I have addressed them and send out a v4 of my patch series.

Thanks,
Anand Kumar

On 6/19/18, 9:14 AM, "Alin Serdean" <aserdean at cloudbasesolutions.com> wrote:

    Thanks a lot for the series and the benchmarks 😊.
    
    This is not an actual review. I applied the patches and ran the code analysis
    and I get the following:
    ovs\datapath-windows\ovsext\conntrack-nat.c(151): warning C28167: The function
    'OvsNatCleanup' changes the IRQL and does not restore the IRQL before it exits.
    It should be annotated to reflect the change or the IRQL should be restored.
    IRQL was last set at line 162.
    
    ovs\datapath-windows\ovsext\conntrack-related.c(147): warning C28167:
    The function 'OvsCtRelatedFlush' changes the IRQL and does not restore the IRQL
    before it exits. It should be annotated to reflect the
    change or the IRQL should be restored. IRQL was last set at line 163. 
    
    ovs\datapath-windows\ovsext\conntrack-related.c(163): warning C6001:
    Using uninitialized memory 'lockState'. 
    
    ovs\datapath-windows\ovsext\conntrack-related.c(163): warning C26110: Caller
    failing to hold lock 'ovsCtRelatedLockObj' before calling function
    'NdisReleaseRWLock'.
    
    ovs\datapath-windows\ovsext\conntrack-related.c(210): warning C28122: The
    function 'NdisReleaseRWLock' is not permitted to be called at a low IRQ level.
    Prior function calls are inconsistent with this constraint: 
    It may be that the error is actually in some prior call that limited the range.
    Maximum legal IRQL was last set to 1 at line 211. 
    
    ovs\datapath-windows\ovsext\conntrack-related.c(176): warning C28166: The
    function 'OvsCtRelatedEntryCleaner' does not restore the IRQL to the value that
    was current at function entry and is required to do so.
    IRQL was last set at line 210. 
    
    ovs\datapath-windows\ovsext\conntrack-related.c(210): warning C6001: Using
    uninitialized memory 'lockState'. 
    
    ovs\datapath-windows\ovsext\conntrack-related.c(210): warning C26110: Caller
    failing to hold lock 'ovsCtRelatedLockObj' before calling function
    'NdisReleaseRWLock'.
    
    Can you please add code annotations where needed?
    
    Thanks,
    Alin.
    
    > -----Mesaj original-----
    > De la: ovs-dev-bounces at openvswitch.org <ovs-dev-
    > bounces at openvswitch.org> În numele Anand Kumar
    > Trimis: Tuesday, June 19, 2018 3:56 AM
    > Către: dev at openvswitch.org
    > Subiect: [ovs-dev] [PATCH v2 0/3] Optimize conntrack performance
    > 
    > This patch series is primarily to refactor conntrack code for better throughput
    > with conntrack.
    > 
    > With this patch series TCP throughput with conntrack increased by ~50%.
    > 
    > Anand Kumar (3):
    >   datapath-windows: Use spinlock instead of RW lock for ct entry
    >   datapath-windows: Implement locking in conntrack NAT.
    >   datapath-windows: Compute ct hash based on 5-tuple and zone
    > 
    >  datapath-windows/ovsext/Conntrack-ftp.c     |   4 +-
    >  datapath-windows/ovsext/Conntrack-nat.c     |  34 +-
    >  datapath-windows/ovsext/Conntrack-related.c |  17 +-
    >  datapath-windows/ovsext/Conntrack-tcp.c     |  15 +-
    >  datapath-windows/ovsext/Conntrack.c         | 469 +++++++++++++------------
    > ---
    >  datapath-windows/ovsext/Conntrack.h         |  40 ++-
    >  datapath-windows/ovsext/Util.h              |  18 ++
    >  7 files changed, 308 insertions(+), 289 deletions(-)
    > 
    > --
    > 2.9.3.windows.1
    > 
    > _______________________________________________
    > dev mailing list
    > dev at openvswitch.org
    > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Ckumaranand%40vmware.com%7C640738ce7d194db0ec1f08d5d5ffce4a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636650217048180105&sdata=afwy4KiFTylRjqBu1K7Qg8cbQdmSfIiXB3%2FrNdkviF0%3D&reserved=0
    



More information about the dev mailing list