[ovs-dev] Automated robotic reply. Re: ...

Aaron Conole aconole at redhat.com
Wed Jun 20 16:12:13 UTC 2018


Justin Pettit <jpettit at ovn.org> writes:

>> On Jun 20, 2018, at 8:47 AM, Ben Pfaff <blp at ovn.org> wrote:
>> 
>>> On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote:
>>> 
>>>> On Jun 20, 2018, at 8:15 AM, Aaron Conole <aconole at redhat.com> wrote:
>>>> 
>>>> 0-day Robot <robot at bytheb.org> writes:
>>>> 
>>>>> Bleep bloop.  Greetings Justin Pettit, I am a robot and I have
>>>>> tried out your patch
>>>>> with message ID  <1529454160-88413-1-git-send-email-jpettit at ovn.org>
>>>>> Thanks for your contribution.
>>>>> 
>>>>> I encountered some error that I wasn't expecting.  See the details below.
>>>>> 
>>>>> 
>>>>> checkpatch:
>>>>> == Checking "0000.patch" ==
>>>>> ERROR: Too many signoffs; are you missing Co-authored-by lines?
>>>>> Lines checked: 118, Warnings: 0, Errors: 1
>>>> 
>>>> I'll fix the sign off check in checkpatch.  It shouldn't flag on these
>>>> kinds of patches.
>>>> 
>>>> Sorry for the noise.
>>> 
>>> No problem.  Thanks for setting it up.  I agree that it shouldn't flag
>>> on this issue, however, the bigger concern I have is that the warning
>>> seems to be separated from the file names, which is a bit confusing.
>>> And, I imagine it would be very confusing if someone had multiple
>>> patches flagged, since it wouldn't be clear which error list applied
>>> to which patch.
>> 
>> What file names?  Sign-offs aren't associated with files.
>
> Sorry, I meant patch name. 

I'll work on the job a bit more.  I've made it manually triggered.  I'll
try and fix a few flaws I've found (mostly false positives).

Thanks for not flaming me :)

> —Justin


More information about the dev mailing list