[ovs-dev] [PATCH] datapath: Fix compiler warning for HAVE_RHEL7_MAX_MTU.

Justin Pettit jpettit at ovn.org
Wed Jun 20 17:16:13 UTC 2018


> On Jun 20, 2018, at 9:22 AM, Gregory Rose <gvrose8192 at gmail.com> wrote:
> 
> On 6/19/2018 2:11 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
>> ---
>>  datapath/vport-internal_dev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
>> index 3fa86815c7fa..629965eab19f 100644
>> --- a/datapath/vport-internal_dev.c
>> +++ b/datapath/vport-internal_dev.c
>> @@ -169,7 +169,7 @@ static void do_setup(struct net_device *netdev)
>>    #ifdef HAVE_NET_DEVICE_WITH_MAX_MTU
>>  	netdev->max_mtu = ETH_MAX_MTU;
>> -#elif HAVE_RHEL7_MAX_MTU
>> +#elif defined(HAVE_RHEL7_MAX_MTU)
>>  	netdev->extended->max_mtu = ETH_MAX_MTU;
>>  #endif
>>  	netdev->netdev_ops = &internal_dev_netdev_ops;
> 
> I didn't bother to test - code inspection is enough to tell me this patch is right.  Maybe add a fixes tag on push?
> 
> Reviewed-by: Greg Rose <gvrose8192 at gmail.com>

Thanks.  I added a "Fixes:" and pushed it to master.

--Justin




More information about the dev mailing list