[ovs-dev] 答复: [PATCH] dpif-netdev:Delete port check in do_add_port

Linhaifeng haifeng.lin at huawei.com
Thu Jun 21 06:24:09 UTC 2018


For the performance problem. When add 3000 or more ports it costs too more time and it is not needed.

port_add function in ofproto-dpif.c have checked it used dpif_port_exists so we really not need to check it again in do_add_port

-----邮件原件-----
发件人: Ben Pfaff [mailto:blp at ovn.org] 
发送时间: 2018年5月10日 5:10
收件人: Linhaifeng <haifeng.lin at huawei.com>
抄送: dev at openvswitch.org
主题: Re: [ovs-dev] [PATCH] dpif-netdev:Delete port check in do_add_port

On Thu, Apr 26, 2018 at 03:12:51PM +0800, Haifeng Lin wrote:
> It is not need check port exist in do_add_port because it had check in 
> port_add.
> 
> Change-Id: Ie66206b40e305cef5f5b20af765c3128ccec6782
> Signed-off-by: Haifeng Lin <haifeng.lin at huawei.com>

Can you explain the problem and the solution in a little more detail?

Thanks,

Ben.


More information about the dev mailing list