[ovs-dev] [ovs-dev, 1 of 3] ipsec: reintroduce IPsec support for tunneling

0-day Robot robot at bytheb.org
Wed Jun 27 18:55:54 UTC 2018


Bleep bloop.  Greetings Qiuyu Xiao, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#372 FILE: debian/openvswitch-ipsec.init:27:
# Description:       The ovs-monitor-ipsec script provides support for encrypting GRE

WARNING: Line is 80 characters long (recommended limit is 79)
#524 FILE: debian/openvswitch-ipsec.init:179:
        log_warning_msg "Reloading $NAME daemon: not implemented, as the daemon"

WARNING: Line is 80 characters long (recommended limit is 79)
#529 FILE: debian/openvswitch-ipsec.init:184:
        echo "Usage: $N {start|stop|force-stop|restart|force-reload|status}" >&2

WARNING: Line is 81 characters long (recommended limit is 79)
#679 FILE: ipsec/ovs-monitor-ipsec:116:
            if len(a) >= 4 and a[0] == "sel" and a[1] == "src" and a[3] == "dst":

WARNING: Line is 80 characters long (recommended limit is 79)
#989 FILE: ipsec/ovs-monitor-ipsec:426:
        self.CHARON_CONF = strongswan_root_prefix + "/etc/strongswan.d/ovs.conf"

WARNING: Line is 94 characters long (recommended limit is 79)
#1066 FILE: ipsec/ovs-monitor-ipsec:503:
            ipsec_conf.write(self.SHUNT_POLICY % (self.in_use_skb_mark, self.in_use_skb_mark))

WARNING: Line is 82 characters long (recommended limit is 79)
#1259 FILE: ipsec/ovs-monitor-ipsec:696:
    seqno = idl.change_seqno  # Sequence number when OVSDB was processed last time

Lines checked: 2515, Warnings: 7, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list