[ovs-dev] [PATCH] ofproto-dpif: Let the dpif report when a port is a duplicate.

Justin Pettit jpettit at ovn.org
Thu Jun 28 00:08:31 UTC 2018

> On Jun 21, 2018, at 3:53 PM, Ben Pfaff <blp at ovn.org> wrote:
> The port_add() function checks whether the port about to be added to the
> dpif is already present and adds it only if it is not.  This duplicates a
> check also present (and necessary) in each dpif and races with it as well.
> When a dpif has a large number of ports, the check can be expensive (it is
> not efficiently implemented).  It would be nice to made the check cheaper,
> but it also seems reasonable to do as done in this patch and just let the
> dpif report the duplication.
> Reported-by: Haifeng Lin <haifeng.lin at huawei.com>
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Acked-by: Justin Pettit <jpettit at ovn.org>


More information about the dev mailing list