[ovs-dev] [PATCHv2] dpif-netlink: Add meter support.

Alin Serdean aserdean at cloudbasesolutions.com
Fri Jun 29 18:06:03 UTC 2018


The incremental looks good.

Thanks,
Alin.

Sent from phone 

> On 29 Jun 2018, at 20:32, Justin Pettit <jpettit at ovn.org> wrote:
> 
> 
>>> On Jun 29, 2018, at 7:23 AM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
>>> 
>>> On 29 Jun 2018, at 07:02, Justin Pettit <jpettit at ovn.org> wrote:
>>> 
>>> @@ -3040,6 +3297,9 @@ dpif_netlink_init(void)
>>>            error = nl_lookup_genl_mcgroup(OVS_VPORT_FAMILY, OVS_VPORT_MCGROUP,
>>>                                           &ovs_vport_mcgroup);
>>>        }
>>> +        if (!error) {
>>> +            error = nl_lookup_genl_family(OVS_METER_FAMILY, &ovs_meter_family);
>>> +        }
>>> 
>>> 
>> It could be ifdef out since the the rest of the communication (get/set) will fail and the
>> userspace can compensate.
>> Please also add a to do comment so I can look on how to implement it later on.
> 
> That was my concern.  Does the incremental at the bottom handle both of those concerns?  If not, can you give me an incremental patch that does what you need?
> 
> Thanks,
> 
> --Justin
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> 
> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
> index fab93b1888a6..d5f14e384155 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -124,6 +124,7 @@ Q: Are all features available with all datapaths?
>     Set action            YES            YES            YES       PARTIAL
>     NIC Bonding           YES            YES            YES       YES
>     Multiple VTEPs        YES            YES            YES       YES
> +    Meters                4.15           YES            YES       NO
>     ===================== ============== ============== ========= =======
> 
>     Do note, however:
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index c79e78ef2ef8..fd176500849c 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -3297,9 +3297,11 @@ dpif_netlink_init(void)
>             error = nl_lookup_genl_mcgroup(OVS_VPORT_FAMILY, OVS_VPORT_MCGROUP,
>                                            &ovs_vport_mcgroup);
>         }
> +#ifndef _WIN32
>         if (!error) {
>             error = nl_lookup_genl_family(OVS_METER_FAMILY, &ovs_meter_family);
>         }
> +#endif
> 
>         ovs_tunnels_out_of_tree = dpif_netlink_rtnl_probe_oot_tunnels();
> 
> 
> 
> 


More information about the dev mailing list