[ovs-dev] [PATCH] datapath-windows: Fix static analysis in Stt.c
Sairam Venugopal
vsairam at vmware.com
Tue Mar 6 17:55:58 UTC 2018
Didn't realize this patch wasn't acked. Please push this in.
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Thanks,
Sairam
On 2/8/18, 9:31 AM, "ovs-dev-bounces at openvswitch.org on behalf of Alin Gabriel Serdean" <ovs-dev-bounces at openvswitch.org on behalf of aserdean at ovn.org> wrote:
The WDK 10 static analysis complains:
stt.c(427): warning C30030: Warning: Allocating executable memory via
specifying a MM_PAGE_PRIORITY type without a bitwise OR with
MdlMappingNoExecute.
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
---
datapath-windows/ovsext/Stt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index e3c4b4686..0220a6e80 100644
--- a/datapath-windows/ovsext/Stt.c
+++ b/datapath-windows/ovsext/Stt.c
@@ -424,8 +424,8 @@ OvsValidateTCPChecksum(PNET_BUFFER_LIST curNbl,
NDIS_STATUS status;
curMdl = NET_BUFFER_CURRENT_MDL(curNb);
- buf = (PUINT8)MmGetSystemAddressForMdlSafe(curMdl, LowPagePriority)
- + NET_BUFFER_CURRENT_MDL_OFFSET(curNb);
+ buf = (PUINT8)OvsGetMdlWithLowPriority(curMdl)
+ + NET_BUFFER_CURRENT_MDL_OFFSET(curNb);
if (!buf) {
status = NDIS_STATUS_INVALID_PACKET;
return status;
--
2.16.1.windows.1
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=BY4WXq8DeAmm1qlGIU6_uzzNUDAh5i6EKM5G_IdrUVI&s=ioWzOV69cv-8RilP53-ycbEfxEQ70f9WRH4NxzRWErU&e=
More information about the dev
mailing list