[ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

[aserdean at ovn.org]

-----Mesaj original-----
De la: ovs-dev-bounces at openvswitch.org <ovs-dev-bounces at openvswitch.org> În numele Ben Pfaff
Trimis: Wednesday, March 7, 2018 10:53 PM
Către: Alin Gabriel Serdean <aserdean at ovn.org>
Cc: dev at openvswitch.org
Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

On Mon, Mar 05, 2018 at 02:40:01PM +0200, Alin Gabriel Serdean wrote:
> Until know we asked users to download a precompiled library of 
> `pthreads` as part of the build chain.
> 
> A big problem with this approach is that the precompiled version of 
> pthreads is built using VS2010 and we must redistribute that runtime 
> to install targets as well.
> 
> The library seems to be abandoned and no longer maintained. I tried to 
> email the authors several times and unfortunately, I haven’t received a reply.
> In the end we might end up maintaining the project under the folder `windows`.
> 
> For now, however we just add the source tarball of the pthread library 
> to the `windows` folder.  We simplify the process of installing and 
> building by compiling pthread library shipped in the `windows` folder 
> during the build step.
> We still allow `--with-pthread=` argument during configure step. If 
> that argument is not specified we fall back to the shipped tarball.
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>

If we need the files in the pthread library, why not check in the files?
It seems more straightforward than checking in the tarball, especially if we need to maintain it ourselves (which seems likely if it is truly abandoned).

What is the license for the pthread library?
[Alin Serdean]
Since we don't need to change any of the files yet,
I thought the tarball (either in the repo or if the user points to a tarball)
would be cleaner for the moment.

I'm okay with checking in the files.

License is LGPL (https://www.sourceware.org/pthreads-win32/copying.html),
I don't know if that would cause any issues.