[ovs-dev] [PATCH v2 1/2] OVN: add icmp4{} action support

Ben Pfaff blp at ovn.org
Fri Mar 9 19:39:05 UTC 2018


On Tue, Feb 20, 2018 at 06:39:43PM +0100, Lorenzo Bianconi wrote:
> icmp4 action is used to replace the IPv4 packet been processed with
> an ICMPv4 packet initialized based on incoming IPv4 one.
> Ethernet and IPv4 fields not listed are not changed:
> - ip.proto = 1 (ICMPv4)
> - ip.frag = 0 (not a fragment)
> - ip.ttl = 255
> - icmp4.type = 3 (destination unreachable)
> - icmp4.code = 1 (host unreachable)
> Prerequisite: ip4
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>

Thank you!

I folded in the two changes below, which looked to me like minor
inconsistencies, and applied this to master.

--8<--------------------------cut here-------------------------->8--

diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
index 67da8a7f47ff..6a8b818a347e 100644
--- a/ovn/ovn-sb.xml
+++ b/ovn/ovn-sb.xml
@@ -1725,7 +1725,7 @@
           <ul>
             <li><code>ip.proto = 1</code> (ICMPv4)</li>
             <li><code>ip.frag = 0</code> (not a fragment)</li>
-            <li><code>ip.ttl = 255</code> (not a fragment)</li>
+            <li><code>ip.ttl = 255</code></li>
             <li><code>icmp4.type = 3</code> (destination unreachable)</li>
             <li><code>icmp4.code = 1</code> (host unreachable)</li>
           </ul>
diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
index 93094eea6c99..00e885a1430d 100644
--- a/ovn/utilities/ovn-trace.c
+++ b/ovn/utilities/ovn-trace.c
@@ -1549,6 +1549,7 @@ execute_icmp4(const struct ovnact_nest *on,
     icmp4_flow.nw_dst = uflow->nw_dst;
     icmp4_flow.nw_src = uflow->nw_src;
     icmp4_flow.nw_proto = IPPROTO_ICMP;
+    icmp4_flow.nw_ttl = 255;
     icmp4_flow.tp_src = htons(ICMP4_DST_UNREACH); /* icmp type */
     icmp4_flow.tp_dst = htons(1); /* icmp code */
 


More information about the dev mailing list