[ovs-dev] [PATCH] odp-util: Fix ofproto/trace with odp flow

Ben Pfaff blp at ovn.org
Wed Mar 14 21:59:49 UTC 2018


On Sat, Mar 10, 2018 at 09:30:34AM -0800, Yi-Hung Wei wrote:
> Currently, using ofproto/trace to trace a datapath flow with eth_type()
> but without eth() may hit unexpected behavior because OVS sets
> the packet_type to be (1, eth_type) when decoding the odp flow key.
> This patch updates the logic of odp flow key decoding so that the
> packet_type defaults to (0,0) unless user explicitly specifies the
> packet_type.  An unit test is added to prevent future regression.
> 
> Travis build: https://travis-ci.org/YiHungWei/ovs/builds/351565383
> 
> Reported-by: Amar Padmanabhan <amarpadmanabhan at fb.com>
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-December/045817.html
> Reported-by: Su Wang <suwang at vmware.com>
> VMWare-BZ: #2070488
> Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>

I posted an alternative proposal:
https://patchwork.ozlabs.org/patch/886052/

I haven't checked that this solves the problem, so I would appreciate
testing.


More information about the dev mailing list