[ovs-dev] [PATCH v9 2/3] dpif-netdev: Detailed performance stats for PMDs

[Stokes, Ian]

> On Wed, Mar 21, 2018 at 01:40:59PM +0000, Stokes, Ian wrote:
> > > -----Original Message-----
> > > From: Jan Scheurich [mailto:jan.scheurich at ericsson.com]
> > > Sent: Sunday, March 18, 2018 5:38 PM
> > > To: Stokes, Ian <ian.stokes at intel.com>; dev at openvswitch.org
> > > Cc: i.maximets at samsung.com
> > > Subject: RE: [ovs-dev] [PATCH v9 2/3] dpif-netdev: Detailed
> > > performance stats for PMDs
> > >
> > > > Checkpatch reports the following:
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #560 FILE: lib/dpif-netdev-perf.h:113:
> > > >     uint64_t cycles;            /* Number of TSC cycles spent in
> it/ms.
> > > */
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #563 FILE: lib/dpif-netdev-perf.h:116:
> > > >     uint32_t pkts;              /* Packets processed in
> iteration/ms. */
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #564 FILE: lib/dpif-netdev-perf.h:117:
> > > >     uint32_t upcalls;           /* Number of upcalls in
> iteration/ms. */
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #565 FILE: lib/dpif-netdev-perf.h:118:
> > > >     uint32_t upcall_cycles;     /* Cycles spent in upcalls in
> > > iteration/ms. */
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #566 FILE: lib/dpif-netdev-perf.h:119:
> > > >     uint32_t batches;           /* Number of rx batches in
> iteration/ms.
> > > */
> > > >
> > > > WARNING: Line lacks whitespace around operator
> > > > #567 FILE: lib/dpif-netdev-perf.h:120:
> > > >     uint32_t max_vhost_qfill;   /* Maximum fill level encountered in
> > > it/ms. */
> > >
> > > These warnings are pretty silly, given that they complain about
> comments.
> > > Somebody should improve checkpatch.py to skip checking comments for
> > > coding style! For now I have modified these comments to avoid the
> warnings.
> > >
> >
> > In this case I agree, it probably doesn't make sense.
> 
> I'd happily accept improvements to checkpatch to avoid these warnings.
> Until then, we have to just ignore them.

I agree Ben, IMO it is a really useful tool & the benefits outweigh the small issues like above which can be fixed over time. I still encourage devs to give it a run before patch submission as is.