[ovs-dev] [PATCH 1/2] ovn-controller: support MAC_Binding aging

Ben Pfaff blp at ovn.org
Sat Mar 31 18:50:42 UTC 2018


On Thu, Mar 15, 2018 at 05:20:11PM +0800, Guoshuai Li wrote:
> Add the MAC_Binding aging. The default aging time is 20 minutes.
> Send the ARP request at 10(1*20/2), 13(2*20/3), 15(3*20/4) minutes.
> If no ARP reply is received within 20 minutes, the MAC_Binding column will be
> deleted.
> 
> Sync a MAC_Binding cache in the ovn-controller where lport redirect chassis,
> to records timestamps and ARP send times. Time traversal cache to send ARP
> requests or aging.
> 
> Signed-off-by: Guoshuai Li <ligs at dtdream.com>

Thanks for working on adding support for this.

In addition to Mark Michelson's comment about IPv6 support, I think that
it is important to document how aging works.  I guess that
ovn/ovn-sb.xml, in the MAC_Binding table, is the right way to do that.
There is already a description of the lifetime of a MAC binding, and
aging could naturally be added to it.

I haven't reviewed the code in this patch yet.  I guess that having the
documentation will make it easier to review, so I'll wait for that.

Thanks,

Ben.


More information about the dev mailing list