[ovs-dev] [PATCH] ovn-controller.at: fix occasional ovn-bridge-mappings test failure

Ben Pfaff blp at ovn.org
Tue May 8 16:02:21 UTC 2018


On Mon, May 07, 2018 at 06:17:28PM -0700, Han Zhou wrote:
> This patch fixes the time issue in the test case so that when external-ids
> is updated in Open_vSwitch OVSDB, give some time for SB OVSDB to get
> updated by ovn-controller.
> 
> Signed-off-by: Han Zhou <hzhou8 at ebay.com>

Thanks for working to make the test cases more reliable.

It would be better to use OVS_WAIT_UNTIL (inside check_bridge_mappings)
to wait until the bridge mappings getting updated, rather than using a
fixed "sleep".  Did you consider that?

Thanks,

Ben.


More information about the dev mailing list