[ovs-dev] [PATCH] ovn-controller: handle multicast group for local datapath only

[Han Zhou]

On Tue, May 8, 2018 at 8:53 AM, Ben Pfaff <blp at ovn.org> wrote:
>
> On Thu, May 03, 2018 at 07:30:56PM -0700, Han Zhou wrote:
> > Most mc related flows are added only if the mc is related to local
> > datapath, but there is a flow added before the local datapath
> > check, out of the function consider_mc_group(). This patch fixes it.
> >
> > Signed-off-by: Han Zhou <hzhou8 at ebay.com>
>
> Thanks for the patch.
>
> Is there anything actually group-specific about this flow?  That is, can
> we just have a single flow of this type instead of one per multicast
> group?
>
Good point! After taking a look at the original code, it seems the flag
MLF_LOCAL_ONLY doesn't have to be used for multicast, although it was
introduced for multicast use case (IPv6 RA). I think we can extract it out
as a single flow per HV, removing the match condition for mc tunnel key.
@Mark, could you confirm this, in case we missed anything?

Thanks,
Han