[ovs-dev] [PATCH] tests: Avoid OVN environment variables leaking into tests.

[Ben Pfaff]

On Wed, May 09, 2018 at 12:24:43PM -0700, Han Zhou wrote:
> On Wed, May 9, 2018 at 11:18 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> > If $OVN_NB_DB or $OVN_SB_DB happened to be set in the environment in which
> > "make check" was invoked, then their values would leak into the tests'
> > environment and interfere with the tests.  This commit avoids that problem.
> >
> > OVS has a number of environment variables too, such as OVS_RUNDIR, but
> > the tests already set those to custom values.
> >
> > Reported-by: Han Zhou <zhouhan at gmail.com>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >  tests/atlocal.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/atlocal.in b/tests/atlocal.in
> > index 6af420c4794f..0cc183e33fa6 100644
> > --- a/tests/atlocal.in
> > +++ b/tests/atlocal.in
> > @@ -195,3 +195,7 @@ unset HTTP_PROXY
> >  unset HTTPS_PROXY
> >  unset FTP_PROXY
> >  unset NO_PROXY
> > +
> > +# Avoid OVN environment variables leaking in from external environment.
> > +unset OVN_NB_DB
> > +unset OVN_SB_DB
> > --
> > 2.16.1
> >
> > This works for me. Thanks Ben!
> 
> Acked-by: Han Zhou <hzhou8 at ebay.com>

Thanks, applied to master.