[ovs-dev] [PATCHv2] tunnel: make tun_key_to_attr aware of tunnel type.
Ben Pfaff
blp at ovn.org
Mon May 14 23:56:58 UTC 2018
On Mon, May 14, 2018 at 04:34:09PM -0700, William Tu wrote:
> On Mon, May 14, 2018 at 4:22 PM, Ben Pfaff <blp at ovn.org> wrote:
> > On Mon, May 14, 2018 at 11:46:47AM -0700, William Tu wrote:
> >> When there is a flow rule which forwards a packet from geneve
> >> port to another tunnel port, ex: gre, the tun_metadata carried
> >> from the geneve port might affect the outgoing port. For example,
> >> the datapath action from geneve port output to gre port (1) shows:
> >> set(tunnel(tun_id=0x7b,dst=2.2.2.2,ttl=64,
> >> geneve({class=0xffff,type=0,len=4,0x123}),flags(df|key))),1
> >> Where the geneve(...) should not exist.
> >>
> >> When using kernel's tunnel port, this triggers an error saying:
> >> "Multiple metadata blocks provided", when there is a rule forwarding
> >> the geneve packet to vxlan/erspan tunnel port. A userspace test case
> >> using geneve and gre also demonstrates the issue.
> >>
> >> The patch makes the tun_key_to_attr aware of the tunnel type. So only
> >> the relevant output tunnel's options are set.
> >>
> >> Reported-by: Xiaoyan Jin <xiaoyanj at vmware.com>
> >> Signed-off-by: William Tu <u9012063 at gmail.com>
> >> Cc: Greg Rose <gvrose8192 at gmail.com>
> >
> > Thanks. Applied to master.
> >
> > Should I backport this?
> >
>
> Yes, thank you.
> Although I hit the issue while testing geneve + erspan, I think
> if using mixture of geneve + vxlan will have the same problem.
Thanks, I backported to 2.8.
More information about the dev
mailing list