[ovs-dev] [PATCH] dpif-netdev-perf: Fix linker unresolved symbols on Windows
Alin Gabriel Serdean
aserdean at ovn.org
Tue May 15 00:48:59 UTC 2018
MSVC complains:
"libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external
symbol pmd_perf_start_iteration referenced in function pmd_thread_main
libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external
symbol pmd_perf_end_iteration referenced in function pmd_thread_main"
Remove inline keyword from the declaration of:
`pmd_perf_start_iteration` and `pmd_perf_end_iteration`
More on the subject:
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/function-inlining-problems
Fixes: broken build on Windows
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
---
lib/dpif-netdev-perf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev-perf.c b/lib/dpif-netdev-perf.c
index 4c6c5cfff..13f1010c9 100644
--- a/lib/dpif-netdev-perf.c
+++ b/lib/dpif-netdev-perf.c
@@ -440,7 +440,7 @@ pmd_perf_stats_clear(struct pmd_perf_stats *s)
/* Functions recording PMD metrics per iteration. */
-inline void
+void
pmd_perf_start_iteration(struct pmd_perf_stats *s)
OVS_REQUIRES(s->stats_mutex)
{
@@ -462,7 +462,7 @@ OVS_REQUIRES(s->stats_mutex)
}
}
-inline void
+void
pmd_perf_end_iteration(struct pmd_perf_stats *s, int rx_packets,
int tx_packets, bool full_metrics)
{
--
2.16.1.windows.1
More information about the dev
mailing list