[ovs-dev] [PATCH 1/7] ofproto-dpif-xlate: Fix reference leak in xlate_dp_hash_select_group().

Justin Pettit jpettit at ovn.org
Wed May 16 23:15:20 UTC 2018


> On May 10, 2018, at 4:24 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> xlate_group_action() takes a reference to the ofgroup and passes it
> down to xlate_group_action__(), xlate_select_group(), and finally to
> xlate_dp_hash_select_group(), which is supposed to consume it but fails
> to do so.  This commit fixes the problem.
> 
> Found by inspection.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>

xlate_group_action__() also calls xlate_all_group().  Should xlate_all_group() include a call to ofproto_group_unref()?

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin




More information about the dev mailing list