[ovs-dev] [PATCH v2] datapath: compat: Fix build on RHEL 7.5

[Yi-Hung Wei]

On Thu, May 17, 2018 at 4:09 AM, Jiri Benc <jbenc at redhat.com> wrote:
> On Fri, 11 May 2018 10:32:12 -0700, Yi-Hung Wei wrote:
>> --- a/datapath/linux/compat/geneve.c
>> +++ b/datapath/linux/compat/geneve.c
>> @@ -1271,7 +1271,11 @@ static const struct net_device_ops geneve_netdev_ops = {
>>       .ndo_stop               = geneve_stop,
>>       .ndo_start_xmit         = geneve_dev_xmit,
>>       .ndo_get_stats64        = ip_tunnel_get_stats64,
>> +#ifdef       HAVE_RHEL7_MAX_MTU
>> +     .extended.ndo_change_mtu = geneve_change_mtu,
>
> Note that this will never be called by the RHEL kernel unless you
> also set .ndo_size to sizeof(struct net_device_ops).
>
> In other words, you've just effectively set .ndo_change_mtu to NULL.
>
>  Jiri

Thanks for bringing up this issue.  I submitted a fix here:
https://patchwork.ozlabs.org/patch/915729/

Thanks,

-Yi-Hung