[ovs-dev] [PATCH V2 38/41] tunnel: add support for erspan and ip6erspan type.

Gregory Rose gvrose8192 at gmail.com
Fri May 18 17:26:37 UTC 2018


On 5/18/2018 10:15 AM, Darrell Ball wrote:
>
> On 5/18/18, 9:58 AM, "ovs-dev-bounces at openvswitch.org on behalf of Gregory Rose" <ovs-dev-bounces at openvswitch.org on behalf of gvrose8192 at gmail.com> wrote:
>
>      On 5/18/2018 9:32 AM, Ben Pfaff wrote:
>      > On Fri, May 18, 2018 at 08:41:54AM -0700, Gregory Rose wrote:
>      >> The other two failures I can repro on the master branch so they are not
>      >> related to this patch series.
>      > What are the other two failures?  Are they reliable failures or due to
>      > races?
>      >
>      > Thanks,
>      >
>      > Ben.
>      
>      This one:
>      
>      1229: ofproto-dpif - in place modification (vlan)     FAILED
>      (ofproto-dpif.at:9009)
>      
>      and this one:
>      
>      2535: ovn -- ensure one gw controller restart in HA doesn't bounce the
>      master FAILED (ovn.at:9059)
>      
>      They seem pretty reliable over a few runs.  I'd have to dig into them in
>      order to see what the failure cause is and I'm pretty limited on time
>      right now.  It Certainly Needs to Be Looked Into.
>      
>      In fact, I just noticed that Darrell has posted a proposed fix for 1229.
>
> Thanks Greg
> Would you mind giving the below patch a check in your environment?
> https://patchwork.ozlabs.org/patch/916469/
>
>      
>      Thanks,
>      
>      - Greg
>      _______________________________________________
>      dev mailing list
>      dev at openvswitch.org
>      https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=P3qys_VoPe-I_rPLCBRrQOhmAsb6biA6e47a2J4wSDs&s=qnlA8lzmYvUAZfBAMZh4UkVTB1OIP3LxVFBygnsiZHU&e=
>      
>

Sure.

I ran:
for i in {1..10}; do make check TESTSUITEFLAGS="1229"; done

Each loop reported:

## ------------------------------ ##
## openvswitch 2.9.90 test suite. ##
## ------------------------------ ##
1229: ofproto-dpif - in place modification (vlan)     ok

## ------------- ##
## Test results. ##
## ------------- ##

1 test was successful.

Looks good.

You can give your patch the "reviewed-by and "tested-by" tags from me if 
you want.

Thanks,

- Greg



More information about the dev mailing list