[ovs-dev] [PATCH V3 02/40] gre: introduce native tunnel support for ERSPAN

[William Tu]

On Fri, May 18, 2018 at 5:49 PM, Greg Rose <gvrose8192 at gmail.com> wrote:
> From: William Tu <u9012063 at gmail.com>
>
> Upstream commit:
>     commit 84e54fe0a5eaed696dee4019c396f8396f5a908b
>     Author: William Tu <u9012063 at gmail.com>
>     Date:   Tue Aug 22 09:40:28 2017 -0700
>
>     gre: introduce native tunnel support for ERSPAN
>
>     The patch adds ERSPAN type II tunnel support.  The implementation
>     is based on the draft at [1].  One of the purposes is for Linux
>     box to be able to receive ERSPAN monitoring traffic sent from
>     the Cisco switch, by creating a ERSPAN tunnel device.
>     In addition, the patch also adds ERSPAN TX, so Linux virtual
>     switch can redirect monitored traffic to the ERSPAN tunnel device.
>     The traffic will be encapsulated into ERSPAN and sent out.
>
>     The implementation reuses tunnel key as ERSPAN session ID, and
>     field 'erspan' as ERSPAN Index fields:
>     ./ip link add dev ers11 type erspan seq key 100 erspan 123 \
>                         local 172.16.1.200 remote 172.16.1.100
>
>     To use the above device as ERSPAN receiver, configure
>     Nexus 5000 switch as below:
>
>     monitor session 100 type erspan-source
>       erspan-id 123
>       vrf default
>       destination ip 172.16.1.200
>       source interface Ethernet1/11 both
>       source interface Ethernet1/12 both
>       no shut
>     monitor erspan origin ip-address 172.16.1.100 global
>
>     [1] https://tools.ietf.org/html/draft-foschiano-erspan-01
>     [2] iproute2 patch: http://marc.info/?l=linux-netdev&m=150306086924951&w=2
>     [3] test script: http://marc.info/?l=linux-netdev&m=150231021807304&w=2
>
>     Signed-off-by: William Tu <u9012063 at gmail.com>
>     Signed-off-by: Meenakshi Vohra <mvohra at vmware.com>
>     Cc: Alexey Kuznetsov <kuznet at ms2.inr.ac.ru>
>     Cc: Hideaki YOSHIFUJI <yoshfuji at linux-ipv6.org>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> This commit also backports heavily from upstream gre, ip_gre and
> ip_tunnel modules to support the necessary erspan ip gre
> infrastructure as well as implementing a variety of compatability
> layer changes for same support.
>
> Cc: William Tu <u9012063 at gmail.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---


Thanks for backporting lots of gre, ip_gre, and ip_tunnel code.
I reviewed most of the ip_gre and ip_tunnel and look good to me.

Acked-by: William Tu <u9012063 at gmail.com>