[ovs-dev] [PATCH V3 07/40] ip_gre: get key from session_id correctly in erspan_rcv

William Tu u9012063 at gmail.com
Mon May 21 21:31:41 UTC 2018


On Fri, May 18, 2018 at 5:49 PM, Greg Rose <gvrose8192 at gmail.com> wrote:
> From: Xin Long <lucien.xin at gmail.com>
>
> Upstream commit:
>     commit 935a9749a36828af0e8be224a5cd4bc758112c34
>     Author: Xin Long <lucien.xin at gmail.com>
>     Date:   Sun Oct 1 22:00:53 2017 +0800
>
>     ip_gre: get key from session_id correctly in erspan_rcv
>
>     erspan only uses the first 10 bits of session_id as the key to look
>     up the tunnel. But in erspan_rcv, it missed 'session_id & ID_MASK'
>     when getting the key from session_id.
>
>     If any other flag is also set in session_id in a packet, it would
>     fail to find the tunnel due to incorrect key in erspan_rcv.
>
>     This patch is to add 'session_id & ID_MASK' there and also remove
>     the unnecessary variable session_id.
>
>     Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
>     Signed-off-by: Xin Long <lucien.xin at gmail.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: Xin Long <lucien.xin at gmail.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

This is a little different than the upstream version.
Since OVS is using the metadata mode, so it looks ok to me.

Acked-by: William Tu <u9012063 at gmail.com>


More information about the dev mailing list