[ovs-dev] [PATCH V3 28/40] openvswitch: fix vport packet length check.

William Tu u9012063 at gmail.com
Tue May 22 00:41:09 UTC 2018


On Fri, May 18, 2018 at 5:49 PM, Greg Rose <gvrose8192 at gmail.com> wrote:
> From: William Tu <u9012063 at gmail.com>
>
> Upstream commit:
>     commit 46e371f0e78a82186a83cbcb4f4b8850417c7dd5
>     Author: William Tu <u9012063 at gmail.com>
>     Date:   Wed Mar 7 15:38:48 2018 -0800
>
>     openvswitch: fix vport packet length check.
>
>     When sending a packet to a tunnel device, the dev's hard_header_len
>     could be larger than the skb->len in function packet_length().
>     In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen,
>     which is around 180, and an ARP packet sent to this tunnel has
>     skb->len = 42.  This causes the 'unsign int length' to become super
>     large because it is negative value, causing the later ovs_vport_send
>     to drop it due to over-mtu size.  The patch fixes it by setting it to 0.
>
>     Signed-off-by: William Tu <u9012063 at gmail.com>
>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: William Tu <u9012063 at gmail.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---

Thanks for backporting this patch.
Acked-by: William Tu <u9012063 at gmail.com>


More information about the dev mailing list