[ovs-dev] [PATCH V3 29/40] erspan: auto detect truncated packets.

William Tu u9012063 at gmail.com
Tue May 22 00:41:50 UTC 2018


On Fri, May 18, 2018 at 5:49 PM, Greg Rose <gvrose8192 at gmail.com> wrote:
> From: William Tu <u9012063 at gmail.com>
>
> Upstream commit:
>     commit 1baf5ebf8954d9bff8fa4e7dd6c416a0cebdb9e2
>     Author: William Tu <u9012063 at gmail.com>
>     Date:   Fri Apr 27 14:16:32 2018 -0700
>
>     erspan: auto detect truncated packets.
>
>     Currently the truncated bit is set only when the mirrored packet
>     is larger than mtu.  For certain cases, the packet might already
>     been truncated before sending to the erspan tunnel.  In this case,
>     the patch detect whether the IP header's total length is larger
>     than the actual skb->len.  If true, this indicated that the
>     mirrored packet is truncated and set the erspan truncate bit.
>
>     I tested the patch using bpf_skb_change_tail helper function to
>     shrink the packet size and send to erspan tunnel.
>
>     Reported-by: Xiaoyan Jin <xiaoyanj at vmware.com>
>     Signed-off-by: William Tu <u9012063 at gmail.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: William Tu <u9012063 at gmail.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---
LGTM.
Acked-by: William Tu <u9012063 at gmail.com>


More information about the dev mailing list