[ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

Ben Pfaff blp at ovn.org
Wed May 23 20:08:56 UTC 2018


On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote:
> ovn-controller abort was found in pinctrl_run() when debugging
> an occasional test case failure of:
>     ovn-controller.at: Chassis external-id

Thanks for finding the problem.

I don't think that this is actually the right solution though:

    ../ovn/controller/pinctrl.c:131:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:147:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:163:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:390:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:684:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:881:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:1454:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:1923:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
    ../ovn/controller/pinctrl.c:2401:17: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]


More information about the dev mailing list