[ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

Han Zhou zhouhan at gmail.com
Thu May 24 01:09:31 UTC 2018


On Wed, May 23, 2018 at 5:15 PM, Ben Pfaff <blp at ovn.org> wrote:
>
> On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote:
> > ovn-controller abort was found in pinctrl_run() when debugging
> > an occasional test case failure of:
> >     ovn-controller.at: Chassis external-id
>
> Thanks a lot.  I think I understand the problem now.
>
> I think that the approach that this patch takes is a bit difficult to
> maintain because it relies on every bit of code that needs to send a
> message checking the OpenFlow version, even if it's been checked earlier
> that the connection is up.
>
> I sent a patch for another approach that seems to me to be easier to
> maintain:
> https://patchwork.ozlabs.org/patch/919461/
> What do you think?

Great! I was not satisfied with my approach either - it was just better
than having crash. Your patch would avoid potential problem for future.
Thanks!


More information about the dev mailing list