[ovs-dev] [PATCH 01/10] ovn-controller: Incremental processing engine

Han Zhou zhouhan at gmail.com
Thu May 24 22:15:13 UTC 2018


On Wed, May 23, 2018 at 4:00 PM, Ben Pfaff <blp at ovn.org> wrote:
>
> On Mon, May 14, 2018 at 07:23:20PM -0700, Han Zhou wrote:
> > This patch implements the engine which will be used in future patches
> > for ovn-controller incremental processing.
> >
> > Signed-off-by: Han Zhou <hzhou8 at ebay.com>
>
> Thanks a lot for working on this.  I read through it in detail and I
> have some comments.  Most of my comments are trivial, so I'll just
> append them in the form of an incremental diff that I hope you will fold
> in.

Thanks for reviewing! I will apply the suggested changes (and I will follow
the style for future patches).

>
> I don't think that engine_get_input() makes sense as an inline
> function.  I would prefer to see it in the .c file.

Agree.

>
> I am not sure whether engine_add_input() makes sense as an inline.

I think it's unnecessary to inline.

I rebased the patch series on master and submitted v2 with suggested
changes applied:

https://patchwork.ozlabs.org/project/openvswitch/list/?series=46497

(Somehow the cover letter always missing in patchwork...)


More information about the dev mailing list