[ovs-dev] [PATCH 3/7] ovs-sim: Convert documentation to RST format.

[Justin Pettit]

> On May 18, 2018, at 2:37 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index babda21defff..d81fcaeb440d 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> ...
> @@ -123,7 +125,7 @@ _man_pages = [
>     ('ovsdb.5',
>      u'Open vSwitch Database (File Formats)'),
>     ('ovsdb.7',
> -     u'Open vSwitch Database (Overview)'),
> +     u'Open vSwitch Database (Overview)',),

Is this added comma intentional?

> diff --git a/Documentation/ref/ovs-sim.1.rst b/Documentation/ref/ovs-sim.1.rst
> new file mode 100644
> index 000000000000..faeee1791050
> --- /dev/null
> +++ b/Documentation/ref/ovs-sim.1.rst
> ...
> +  See `Commands`_, below, for an explanation.
> +
> +4. Runs  any  scripts  specified on the command line (see Options

Do you want to specify a link by referring to it as "`Options`_,"?

> diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox
> index 9505c6c3d98b..aa60b9bc3157 100755
> --- a/tutorial/ovs-sandbox
> +++ b/tutorial/ovs-sandbox
> ...
> +    for i in $(seq $n_controllers); do
> +	rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \
> +               $OVN_CTRLR_PKI --detach --no-chdir --pidfile -vconsole:off --log-file
> +    done

Do you want to distinguish the separate ovn-controller instance pidfiles and logfiles by integrating a name with "$i" in it?

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin