[ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

Sriharsha Basavapatna sriharsha.basavapatna at broadcom.com
Thu Nov 1 04:02:50 UTC 2018


On Thu, Nov 1, 2018 at 5:32 AM Flavio Leitner <fbl at sysclose.org> wrote:
>
>
> Hi Sriharsha,
>
> Do you mind to send this again but directly to
> dev at openvswitch.org
> instead of
> ovs-dev at openvswitch.org ?
>
> I received spam with the same issue but only when sent to
> ovs-dev@
>
> Thanks,
> fbl

Hi Flavio,

Thanks for chiming in. But I did send it to "dev at openvswitch.org".
Here's the send-email command I used:
# git send-email --from="Sriharsha Basavapatna
<sriharsha.basavapatna at broadcom.com>" --to dev at openvswitch.org
./0001-dpif-Restore-a-few-lines-with-form-feed-characters.patch

Thanks,
-Harsha

>
> On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev wrote:
> > A few lines with form feed characters (ASCII: ^L) were accidentally
> > deleted by a recent commit to support rebalancing of offloaded flows.
> > This patch reverts those lines.
> >
> > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows")
> > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> > ---
> >  lib/dpif.c                    | 2 +-
> >  lib/dpif.h                    | 2 +-
> >  ofproto/ofproto-dpif-upcall.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/dpif.c b/lib/dpif.c
> > index 7f981328e..59aa1dc7c 100644
> > --- a/lib/dpif.c
> > +++ b/lib/dpif.c
> > @@ -1661,7 +1661,7 @@ dpif_queue_to_priority(const struct dpif *dpif, uint32_t queue_id,
> >      log_operation(dpif, "queue_to_priority", error);
> >      return error;
> >  }
> > -
> > +
> >  void
> >  dpif_init(struct dpif *dpif, const struct dpif_class *dpif_class,
> >            const char *name,
> > diff --git a/lib/dpif.h b/lib/dpif.h
> > index 0df856d4f..475d5a674 100644
> > --- a/lib/dpif.h
> > +++ b/lib/dpif.h
> > @@ -769,7 +769,7 @@ struct dpif_op {
> >
> >  void dpif_operate(struct dpif *, struct dpif_op **ops, size_t n_ops,
> >                    enum dpif_offload_type);
> > -
> > +
> >  /* Upcalls. */
> >
> >  enum dpif_upcall_type {
> > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
> > index 28172cb05..e36cfa0ee 100644
> > --- a/ofproto/ofproto-dpif-upcall.c
> > +++ b/ofproto/ofproto-dpif-upcall.c
> > @@ -1010,7 +1010,7 @@ udpif_revalidator(void *arg)
> >
> >      return NULL;
> >  }
> > -
> > +
> >  static enum upcall_type
> >  classify_upcall(enum dpif_upcall_type type, const struct nlattr *userdata,
> >                  struct user_action_cookie *cookie)
> > --
> > 2.18.0.rc1.1.g6f333ff
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> --
> Flavio
>


More information about the dev mailing list