[ovs-dev] [PATCH] odp-util: Validate close-brace in scan_geneve and fix return values of san_xxx functions

[Ben Pfaff]

Thanks.  Would you mind adding that information to the commit message?

On Thu, Nov 01, 2018 at 09:55:35AM -0700, Yifeng Sun wrote:
> I found this issue while surveying an oss-fuzz report, but I can't reason
> out
> whether this fix is related to that report.
> 
> An simple example will be set(encap(tunnel(geneve({{)))). When scan_geneve
> returns, (struct geneve_scan *key)->len equals to 2*sizeof(struct
> geneve_opt).
> That seems not correct.
> 
> On Thu, Nov 1, 2018 at 8:08 AM Ben Pfaff <blp at ovn.org> wrote:
> 
> > On Wed, Oct 31, 2018 at 06:43:24PM -0700, Yifeng Sun wrote:
> > > This patch adds validation of close-braces in scan_geneve.
> > >
> > > In addition, SCAN_TYPE expects scan_XXX functions to return 0
> > > on errors. This patch inspects all related scan_XXX functions
> > > and fixes their return values.
> > >
> > > Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
> >
> > Thanks a lot for fixing this code.
> >
> > Is this prompted by an oss-fuzz report?  Do you have an example of input
> > that it fixes?
> >
> > Thanks,
> >
> > Ben.
> >