[ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Don't flush datapath flows in quiescent state.

Ben Pfaff blp at ovn.org
Thu Nov 1 18:30:53 UTC 2018


On Thu, Nov 01, 2018 at 04:58:41PM +0300, Ilya Maximets wrote:
> Datapath implementation of 'flow_flush()' could use cmaps.
> dpif-netdev actively uses them to store flow tables and the polling
> threads. Flushing flows while in a quiescent state may lead to
> wrong memory accesses because implementaion of concurrent hash maps
> relies on the rcu protected pointers which could float away.
> 
> CC: Alex Wang <ee07b291 at gmail.com>
> Fixes: 1f8675481e8c ("ofproto-dpif-upcall: Fix ovs-vswitchd crash.")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

I think this patch becomes unnecessary if my logic for the first one is
correct.


More information about the dev mailing list