[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

Ben Pfaff blp at ovn.org
Fri Nov 2 23:16:59 UTC 2018


On Fri, Nov 02, 2018 at 01:57:08PM -0700, Gregory Rose wrote:
> On 11/2/2018 1:46 PM, Ben Pfaff wrote:
> >On Fri, Nov 02, 2018 at 08:31:06AM -0700, Gregory Rose wrote:
> >>On 11/2/2018 4:45 AM, Jaime Caamaño Ruiz wrote:
> >>>Upstream commit:
> >>>     commit 46ebe2834ba5b541f28ee72e556a3fed42c47570
> >>>     Author: Jaime Caamaño Ruiz <jcaamano at suse.com>
> >>>     Date:   Wed Oct 31 18:52:03 2018 +0100
> >>>
> >>>     openvswitch: Fix push/pop ethernet validation
> >>>
> >>>     When there are both pop and push ethernet header actions among the
> >>>     actions to be applied to a packet, an unexpected EINVAL (Invalid
> >>>     argument) error is obtained. This is due to mac_proto not being reset
> >>>     correctly when those actions are validated.
> >>>
> >>>     Reported-at:
> >>>     https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html
> >>>     Fixes: 91820da6ae85 ("openvswitch: add Ethernet push and pop actions")
> >>>     Signed-off-by: Jaime Caamaño Ruiz <jcaamano at suse.com>
> >>>
> >>>Reported-at:
> >>>https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html
> >>>Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions")
> >>>Signed-off-by: Jaime Caamaño Ruiz <jcaamano at suse.com>
> >Applied to master, thanks Jaime and Greg!
> 
> Thanks Ben!  It looks like it needs backporting to 2.10 and 2.9 as well.

Done.


More information about the dev mailing list